rdblue commented on pull request #3056: URL: https://github.com/apache/iceberg/pull/3056#issuecomment-1038358431
@ConeyLiu, I think we should simplify the way that the tests are happening. This should just validate that the data and metadata files for the table are deleted after a purge or not deleted when not purged. I don't think there is a need for custom catalogs or anything that is specific to the catalog that is used. In addition, I think we need to fail `PURGE` if the table has `gc.enabled=true` in table properties. The thread discussing this is long and covers a few other topics, but I think there's agreement about handling `gc.enabled`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
