singhpk234 opened a new pull request #4133: URL: https://github.com/apache/iceberg/pull/4133
### About Change Attribute exposes functions such as withNullability which can be used. Incase of AttributeRef this is existing impl : [CodePointer](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala#L306-L312) ``` /** * Returns a copy of this [[AttributeReference]] with changed nullability. */ override def withNullability(newNullability: Boolean): AttributeReference = { if (nullable == newNullability) { this } else { AttributeReference(name, dataType, newNullability, metadata)(exprId, qualifier) } } ``` As per my understanding, our intention was only to change nullablity we should use this rather than creating new AttributeRef obj --- ### Testing Done ran TestMerge locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
