RussellSpitzer commented on a change in pull request #4124:
URL: https://github.com/apache/iceberg/pull/4124#discussion_r806271232
##########
File path: docs/versioned/spark/spark-getting-started.md
##########
@@ -39,10 +39,9 @@ spark-shell --packages
org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:{{% ice
```
{{< hint info >}}
-If you want to include Iceberg in your Spark installation, add the
[`iceberg-spark-runtime-3.2_2.12` Jar][spark-runtime-jar] to Spark's `jars`
folder.
+If you want to include Iceberg in your Spark installation, add the
[`iceberg-spark-runtime-3.2_2.12`
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar)
to Spark's `jars` folder.
{{< /hint >}}
-[spark-runtime-jar]:
https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar
Review comment:
we could change this reference instead of inlining it too, I have no
preference
##########
File path: docs/versioned/spark/spark-getting-started.md
##########
@@ -39,10 +39,9 @@ spark-shell --packages
org.apache.iceberg:iceberg-spark-runtime-3.2_2.12:{{% ice
```
{{< hint info >}}
-If you want to include Iceberg in your Spark installation, add the
[`iceberg-spark-runtime-3.2_2.12` Jar][spark-runtime-jar] to Spark's `jars`
folder.
+If you want to include Iceberg in your Spark installation, add the
[`iceberg-spark-runtime-3.2_2.12`
Jar](https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar)
to Spark's `jars` folder.
{{< /hint >}}
-[spark-runtime-jar]:
https://search.maven.org/remotecontent?filepath=org/apache/iceberg/iceberg-spark-runtime-3.2_2.12/{{%
icebergVersion %}}/iceberg-spark-runtime-3.2_2.12-{{% icebergVersion %}}.jar
Review comment:
🕺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
