jackye1995 commented on a change in pull request #56:
URL: https://github.com/apache/iceberg-docs/pull/56#discussion_r807496440
##########
File path: landing-page/content/common/community/contribute.md
##########
@@ -163,6 +172,12 @@ When passing boolean arguments to existing or external
methods, use inline comme
2. Use `.` to create a hierarchy of config groups
* For example, `s3` in `s3.access-key-id`, `s3.secret-access-key`
+## Running Benchmarks
+Some PRs/changesets might require running benchmarks to determine whether they
are affecting the baseline performance. Currently there is
+no "push a single button to get a performance comparison" solution available,
therefore one has to run JMH performance tests on their local machine and
+post the results on the PR.
+
+See [Benchmarks](../benchmarks) for a summary of available benchmarks and how
to run them.
Review comment:
nit: newline before new section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
