ajantha-bhat commented on a change in pull request #4138:
URL: https://github.com/apache/iceberg/pull/4138#discussion_r807575175
##########
File path: core/src/main/java/org/apache/iceberg/SetSnapshotOperation.java
##########
@@ -113,7 +113,7 @@ public void commit() {
.run(taskOps -> {
Snapshot snapshot = apply();
TableMetadata updated = TableMetadata.buildFrom(base)
- .setCurrentSnapshot(snapshot.snapshotId())
+ .setBranchSnapshot(snapshot.snapshotId(),
SnapshotRef.MAIN_BRANCH)
Review comment:
rollback can be branch specific operation right?
As user will pass specific branch's snapshot id. We need a validation to
check if the user passed snapshot is present in this branch or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
