danielcweeks commented on a change in pull request #4050: URL: https://github.com/apache/iceberg/pull/4050#discussion_r808235789
########## File path: api/src/main/java/org/apache/iceberg/io/FileIOMetricsContext.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import org.apache.iceberg.metrics.MetricsContext; + +/** + * Extension of MetricsContext for use with FileIO to define standard metrics + * that should be reported. + */ +public interface FileIOMetricsContext extends MetricsContext { Review comment: Yes, these are metrics that are specific to file system operations to distinguish from other operations. We could collapse them all, but it could get confusing and maybe we don't want to reuse the same names for different usages. The unit should be defined by the producer, not required by the metric. For example, one file IO impl could produce bytes while the other could produce kilobytes. As long as they annotate the unit they're producing correctly, it should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
