RussellSpitzer commented on a change in pull request #4140:
URL: https://github.com/apache/iceberg/pull/4140#discussion_r808420144
##########
File path: core/src/main/java/org/apache/iceberg/TableScanContext.java
##########
@@ -54,10 +54,18 @@
this.toSnapshotId = null;
}
- private TableScanContext(Long snapshotId, Expression rowFilter, boolean
ignoreResiduals,
- boolean caseSensitive, boolean colStats, Schema
projectedSchema,
- Collection<String> selectedColumns,
ImmutableMap<String, String> options,
- Long fromSnapshotId, Long toSnapshotId) {
+ private TableScanContext(
+ Long snapshotId,
Review comment:
While I personally like this format, in Iceberg we stick to the version
that was here before with all the args grouped together and left justified with
the first arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
