danielcweeks commented on a change in pull request #4050: URL: https://github.com/apache/iceberg/pull/4050#discussion_r808447528
########## File path: api/src/main/java/org/apache/iceberg/io/FileIOMetricsContext.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import org.apache.iceberg.metrics.MetricsContext; + +/** + * Extension of MetricsContext for use with FileIO to define standard metrics + * that should be reported. + */ +public interface FileIOMetricsContext extends MetricsContext { Review comment: `FileIO` does not specifically require a sub-interface. You can see that S3FileIO only as a handle on a `MetricsContext`. The only reason for the sub-interface is to have a place to put FileIO specific things, though right now that is only the name of the generic metric names. These metrics need to be translated by the metrics implementations (in the hadoop case it would be `read.bytes -> statistics.incrementBytesRead()`). We cannot put the metric names in the HadoopMetricsContext because that would pull in dependencies that would fail class loading when hadoop is not available. Alternatively we could just have a an interface/class as the holder for FileIO Metrics, but since this is scoped to usage within the FileIO space, it makes sense to just define a sub-interface to expose the metrics names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
