rdblue commented on a change in pull request #4115:
URL: https://github.com/apache/iceberg/pull/4115#discussion_r808520892



##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -98,6 +98,15 @@
    */
   ExpireSnapshots executeDeleteWith(ExecutorService executorService);
 
+  /**
+   * Passes an alternative executor service that will be used for accessing 
manifests.
+   * If this method is not called, the default worker pool will be used.
+   *
+   * @param executorService an executor service to access manifests
+   * @return this for method chaining
+   */
+  ExpireSnapshots accessManifestsWith(ExecutorService executorService);

Review comment:
       The methods that run this are named `plan`: `planFiles` and `planSplits` 
so I'd probably change this to `planWith`. Is that okay with you, @yittg?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to