rdblue commented on a change in pull request #4132:
URL: https://github.com/apache/iceberg/pull/4132#discussion_r808524777
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/EqualityDeleteWriter.java
##########
@@ -58,8 +60,9 @@ public EqualityDeleteWriter(FileAppender<T> appender,
FileFormat format, String
}
@Override
- public void write(T row) {
+ public PathOffset write(T row) {
appender.add(row);
+ return PathOffset.of(location, recordCount++);
Review comment:
In Iceberg, we don't use the return value of `++` operators because it
is hard to read code that uses them. Can you move the increment to a separate
line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
