szehon-ho commented on a change in pull request #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r808661327
##########
File path: core/src/main/java/org/apache/iceberg/PartitionsTable.java
##########
@@ -167,16 +175,30 @@ Partition get(StructLike key) {
private final StructLike key;
private long recordCount;
private int fileCount;
+ private int deleteFileCount;
+ private long equalityDeleteCount;
+ private long positionDeleteCount;
Partition(StructLike key) {
this.key = key;
this.recordCount = 0;
this.fileCount = 0;
+ this.deleteFileCount = 0;
+ this.equalityDeleteCount = 0L;
+ this.positionDeleteCount = 0L;
}
- void update(DataFile file) {
- this.recordCount += file.recordCount();
+ void update(FileScanTask task) {
+ this.recordCount += task.file().recordCount();
this.fileCount += 1;
+ this.deleteFileCount += task.deletes().size();
Review comment:
Would this ever have duplicates? Example multiple fileScanTask within
the same partition referring to the same delete file, would this value be too
high?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
