szehon-ho commented on a change in pull request #2925:
URL: https://github.com/apache/iceberg/pull/2925#discussion_r809397547
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -379,24 +423,63 @@ private void
validateNoNewDeletesForDataFiles(TableMetadata base, Long startingS
*
* @param base table metadata to validate
* @param startingSnapshotId id of the snapshot current at the start of the
operation
- * @param dataFilter an expression used to find new conflicting delete files
+ * @param dataFilter an expression used to filter new conflicting delete
files
Review comment:
Basically i wrote 'filter' in all the new methods then came back and saw
this existing method said 'find' and thought to change that. Changed all of
the new javadocs to 'find' instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
