wypoon commented on a change in pull request #4135:
URL: https://github.com/apache/iceberg/pull/4135#discussion_r809435038
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -501,6 +501,10 @@ public TableMetadata replaceCurrentSnapshot(Snapshot
snapshot) {
return new Builder(this).setCurrentSnapshot(snapshot).build();
}
+ public TableMetadata replaceCurrentSnapshot(long snapshotId) {
+ return new Builder(this).setCurrentSnapshot(snapshotId).build();
+ }
+
Review comment:
I think this was an oversight, right? We don't need this new method; it
is not used.
In fact, with the above change to `SnapshotProducer`, even
`replaceCurrentSnapshot(Snapshot)` is no longer used and can be removed, I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
