RussellSpitzer commented on a change in pull request #3056:
URL: https://github.com/apache/iceberg/pull/3056#discussion_r809456911
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java
##########
@@ -237,6 +237,13 @@ public boolean dropTable(Identifier ident) {
return icebergCatalog.dropTable(ident) ||
getSessionCatalog().dropTable(ident);
}
+ @Override
+ public boolean purgeTable(Identifier ident) {
+ // no need to check table existence to determine which catalog to use. if
a table doesn't exist then both are
+ // required to return false.
+ return icebergCatalog.purgeTable(ident) ||
getSessionCatalog().purgeTable(ident);
Review comment:
Quick check here, we are safe in the GC_ENABLED situation because
iceberg.purge will throw a runtime exception correct? Just want to make sure we
don't call purge in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
