dramaticlly commented on a change in pull request #4052:
URL: https://github.com/apache/iceberg/pull/4052#discussion_r809621260
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
##########
@@ -208,8 +212,49 @@ public void testClientFactorySerialization() throws
Exception {
validateRead(fileIO2);
}
+ @Test
+ public void testDeleteFilesMultipleBatches() throws Exception {
+ S3FileIO s3FileIO = new S3FileIO(clientFactory::s3,
getDeletionTestProperties());
+ testDeleteFiles(6, s3FileIO);
Review comment:
nit, maybe I would think about put it like `deletionBatchSize * 2`
same as below
- for lessThan, we can do `deletionBatchSize-1`
- for SingleWithRemainer do `deletionBatchSize+1`
so it shall help with understanding and hopefully more robust if
`deletionBatchSize` get changed somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
