happyprg commented on a change in pull request #4151:
URL: https://github.com/apache/iceberg/pull/4151#discussion_r809624175
##########
File path: docs/versioned/api/python-api-intro.md
##########
@@ -36,7 +36,8 @@ To create a catalog:
from iceberg.hive import HiveTables
# instantiate Hive Tables
-conf = {"hive.metastore.uris": 'thrift://{hms_host}:{hms_port}'}
+conf = {"hive.metastore.uris": 'thrift://{hms_host}:{hms_port}',
+ "hive.metastore.warehouse.dir": tmpdir}
Review comment:
@dramaticlly
Thank you for giving me good direction.
I changed text `tmpdir` to `{tmpdir}`. [following current
convention(replacement
text)](https://github.com/apache/iceberg/pull/4151/files#diff-e2fa3022513566d7037734d0c167b142be6f86df26aa59fe5548eff6182dd15bL39)
I think it is more simple and keep following current convention, how about
this?
Firstly, I tried resolving `tmpdir` using
[docs.python.org/3/library/tempfile.html#module-tempfile](https://docs.python.org/3/library/tempfile.html#module-tempfile),
but I failed.
and If I want to fix it, it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
