hililiwei commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r810467766
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -331,6 +342,7 @@ public Builder setSnapshotProperty(String property, String
value) {
* @return {@link DataStreamSink} for sink.
*/
public DataStreamSink<Void> append() {
+ buildProperties();
Review comment:
I've done the first two steps here, building the table first and merging
the configuration. In the third step, instead of passing table and props into
the chainIcebergOperators, I directly use member field in
chainIcebergOperators, is this feasible? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
