rdblue commented on a change in pull request #4011:
URL: https://github.com/apache/iceberg/pull/4011#discussion_r810540646
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/HadoopTableTestBase.java
##########
@@ -170,10 +172,15 @@ void rewriteMetadataAsGzipWithOldExtension() throws
IOException {
}
protected HadoopCatalog hadoopCatalog() throws IOException {
+ return hadoopCatalog(Collections.emptyMap());
+ }
+
+ protected HadoopCatalog hadoopCatalog(Map<String, String> catalogProperties)
throws IOException {
HadoopCatalog hadoopCatalog = new HadoopCatalog();
hadoopCatalog.setConf(new Configuration());
hadoopCatalog.initialize("hadoop",
- ImmutableMap.of(CatalogProperties.WAREHOUSE_LOCATION,
temp.newFolder().getAbsolutePath()));
+ ImmutableMap.<String,
String>builder().putAll(catalogProperties).put(CatalogProperties.WAREHOUSE_LOCATION,
+ temp.newFolder().getAbsolutePath()).build());
Review comment:
Style: In Iceberg, try to wrap lines at the highest semantic level
possible, rather than trying to use the whole line. In this case, it is awkward
that `temp.newFolder()...` is on its own line because it's inside a method call.
I'd change it to this:
```java
hadoopCatalog.initialize("hadoop",
ImmutableMap.<String, String>builder()
.putAll(catalogProperties)
.put(CatalogProperties.WAREHOUSE_LOCATION,
temp.newFolder().getAbsolutePath())
.build());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
