ggershinsky commented on a change in pull request #3471: URL: https://github.com/apache/iceberg/pull/3471#discussion_r810575986
########## File path: core/src/main/java/org/apache/iceberg/encryption/EnvelopeEncryptionManager.java ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.encryption; + +import java.nio.ByteBuffer; +import java.security.SecureRandom; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Encryption manager that performs envelope encryption. + */ +public class EnvelopeEncryptionManager implements EncryptionManager { + private final EnvelopeConfig dataEncryptionConfig; + private final boolean pushdown; + private final KmsClient kmsClient; + private final int dataKeyLength; + + private transient volatile SecureRandom workerRNG = null; Review comment: this field is transient, not passed in serialization. It is used locally only, and could have been a fully local var, defined and init each time a function is called. But since creating a secure random gen can be expensive, it is defined as a class member and kept for a while -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
