jackye1995 commented on a change in pull request #4052:
URL: https://github.com/apache/iceberg/pull/4052#discussion_r810577713
##########
File path: aws/src/test/java/org/apache/iceberg/aws/TestAwsProperties.java
##########
@@ -97,4 +97,24 @@ public void testS3MultipartThresholdFactorLessThanOne() {
() -> new AwsProperties(map));
}
+ @Test
+ public void testS3FileIoDeleteBatchSizeTooLarge() {
+ Map<String, String> map = Maps.newHashMap();
+ map.put(AwsProperties.S3FILEIO_DELETE_BATCH_SIZE, "2000");
+ AssertHelpers.assertThrows("should not accept batch size greater than
1000",
+ IllegalArgumentException.class,
Review comment:
the indentations in tests seem to be off? I think it should have 4 indent
##########
File path: aws/src/test/java/org/apache/iceberg/aws/TestAwsProperties.java
##########
@@ -97,4 +97,24 @@ public void testS3MultipartThresholdFactorLessThanOne() {
() -> new AwsProperties(map));
}
+ @Test
+ public void testS3FileIoDeleteBatchSizeTooLarge() {
+ Map<String, String> map = Maps.newHashMap();
+ map.put(AwsProperties.S3FILEIO_DELETE_BATCH_SIZE, "2000");
+ AssertHelpers.assertThrows("should not accept batch size greater than
1000",
+ IllegalArgumentException.class,
Review comment:
the indentations in tests seem to be wrong? I think it should have 4
indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
