rdblue commented on a change in pull request #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r810674767
##########
File path: core/src/main/java/org/apache/iceberg/PartitionsTable.java
##########
@@ -48,7 +48,10 @@
this.schema = new Schema(
Types.NestedField.required(1, "partition",
table.spec().partitionType()),
Types.NestedField.required(2, "record_count", Types.LongType.get()),
- Types.NestedField.required(3, "file_count", Types.IntegerType.get())
+ Types.NestedField.required(3, "file_count", Types.IntegerType.get()),
+ Types.NestedField.required(4, "delete_file_count",
Types.IntegerType.get()),
+ Types.NestedField.required(5, "equality_delete_count",
Types.LongType.get()),
Review comment:
I agree. It would be better to use `file` and `record` to clarify what
each count means.
It would also be nice to rename `file_count`, but that probably isn't a good
idea because it would break existing queries. Instead, we should add field docs
to explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
