stevenzwu commented on a change in pull request #4060:
URL: https://github.com/apache/iceberg/pull/4060#discussion_r810750507



##########
File path: 
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
##########
@@ -192,12 +194,12 @@ ScanContext copyWithAppendsBetween(long 
newStartSnapshotId, long newEndSnapshotI
         .project(schema)
         .filters(filters)
         .limit(limit)
-        .exposeLocality(exposeLocality)

Review comment:
       this reordering is to match the order where variables are defined. 
   
   `copyWithSnapshotId(long newSnapshotId)` below also has the matching order




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to