[GitHub] [iceberg] kbendick commented on a change in pull request #4097: REST Catalog - Initial Http Client Interface & Basic Implementation

Mon, 21 Feb 2022 14:39:12 -0800 


kbendick commented on a change in pull request #4097:
URL: https://github.com/apache/iceberg/pull/4097#discussion_r811461579



##########
File path: build.gradle
##########
@@ -221,6 +223,8 @@ project(':iceberg-core') {
       exclude group: 'org.slf4j', module: 'slf4j-log4j12'
     }
 
+    implementation 'org.apache.httpcomponents.client5:httpclient5'

Review comment:
       The JAR itself is about 779 kb (so not small)
   
   
![image](https://user-images.githubusercontent.com/9833362/155034136-3695a704-4863-4988-8354-506fa7d076c1.png)
   
   And then it has the following compile time dependencies as well
   
   
![image](https://user-images.githubusercontent.com/9833362/155034203-220531a3-6c8d-4961-abac-e14cee20b010.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to