samredai commented on pull request #4174: URL: https://github.com/apache/iceberg/pull/4174#issuecomment-1047381823
LGTM! I think it'd be helpful to describe the design we settled on here to achieve singleton behavior, possibly in the module level docstring. That's nothing that needs to hold this PR up though and actually I can include that in a future PR I'm planning which adds docstrings in some other files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
