rdblue commented on a change in pull request #3987:
URL: https://github.com/apache/iceberg/pull/3987#discussion_r812208486



##########
File path: flink/v1.14/build.gradle
##########
@@ -67,6 +67,7 @@ project(':iceberg-flink:iceberg-flink-1.14') {
       exclude group: 'org.apache.hive', module: 'hive-storage-api'
     }
 
+    testImplementation "org.apache.spark:spark-sql_2.12:3.2.0"

Review comment:
       I actually prefer using the Spark module, unless Flink natively supports 
writing INT96 timestamps to Parquet. The benefit of using the Spark module is 
that support has been around for a long time and is relatively trusted to 
produce correct INT96 timestamp values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to