stevenzwu edited a comment on pull request #4189:
URL: https://github.com/apache/iceberg/pull/4189#issuecomment-1048429340


   @openinx I have run the test hundreds of times locally in a test loop like 
you did before and was never able to reproduce it.
   
   Think again about the root cause that we discussed in the issue where we may 
miss the notifyCheckpointComplete callback. I am not sure this change to 
BoundedTestSource will help. It is not about how many rows in one checkpoint 
cycle. The real issue is that two checkpoint cycles got squashed into one 
Iceberg commit and hence have 2 files for a partition in one Iceberg commit. 
   
   I misunderstood the PR earlier. Looks like the change is to make sure we 
have one checkpoint cycle for all rows to avoid the problem.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to