aokolnychyi commented on a change in pull request #4154:
URL: https://github.com/apache/iceberg/pull/4154#discussion_r812553469
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java
##########
@@ -171,11 +173,13 @@ public ThisT tableProperty(String name) {
}
protected T parse(Function<String, T> conversion, T defaultValue) {
- if (optionName != null) {
- // use lower case comparison as DataSourceOptions.asMap() in Spark 2
returns a lower case map
- String optionValue = options.get(optionName.toLowerCase(Locale.ROOT));
- if (optionValue != null) {
- return conversion.apply(optionValue);
+ if (!optionNames.isEmpty()) {
Review comment:
Looks correct to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
