openinx commented on pull request #4193: URL: https://github.com/apache/iceberg/pull/4193#issuecomment-1049455989
> If I understand correctly, the idea here is that because this is binary compatible using Flink's Java API, we don't need to care about what version of Scala was used in the Flink artifact. Correct. > I don't think that I agree because if you rely on the Iceberg Flink Jar, it could transitively pull in flink-scala_2.12. It won't pull in any flink scala artifact actually because all of the flink related artifacts are introduced as `compileOnly` in the [build.gradle](https://github.com/apache/iceberg/blob/master/flink/v1.14/build.gradle#L36). People will need to add their own flink scala jars ( with scala 2.12 or scala 2.11). So, I think our iceberg-flink artifact without scala version doesn't bring its scala transitive jar and cause user confusion. > Or we could remove the transitive dependency and remove the Scala version suffix from all the Jars. It's definitely the correction approach for our next flink 1.15, but not possible for flink 1.14 currently. As this https://github.com/apache/iceberg/pull/4193#issuecomment-1048409144 said, flink 1.15 will remove all the scala version for all the user required artifacts, but flink 1.14 only clean part of the artifacts to remove scala version. Although we iceberg-flink modue introduce the flink artifact with scala versions, but it not require the iceberg flink modules to attach the scala version because the iceberg-flink module does not use any scala code or depends on scala-related APIs, nor does it introduce transitive flink scala dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
