snazy commented on a change in pull request #4210:
URL: https://github.com/apache/iceberg/pull/4210#discussion_r813575200
##########
File path: .github/workflows/flink-ci.yml
##########
@@ -19,27 +19,13 @@
name: "Flink CI"
on:
- push:
Review comment:
This would stop running CI on the master branch. Just needs another
attribute:
```
branches: [ master ]
```
##########
File path: .github/workflows/flink-ci.yml
##########
@@ -19,27 +19,13 @@
name: "Flink CI"
on:
- push:
- paths-ignore:
- - '.github/workflows/python-ci.yml'
- - '.github/workflows/spark-ci.yml'
- - '.github/workflows/hive-ci.yml'
- - '.github/workflows/cancel-duplicate-workflow-runs.yml'
- - '.gitignore'
- - 'dev/**'
- - 'mr/**'
- - 'hive3/**'
- - 'hive3-orc-bundle/**'
- - 'hive-runtime/**'
- - 'spark/**'
- - 'pig/**'
- - 'python/**'
- - 'python_legacy/**'
- - 'docs/**'
- - '.gitattributes'
- - 'README.md'
- - 'CONTRIBUTING.md'
pull_request:
+ types:
+ - opened
+ - reopened
+ - ready_for_review
Review comment:
I suspect, it's fine to omit `ready_for_review`, because it's only a
change on "PR metadata" and CI should have already been triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
