openinx commented on a change in pull request #4221:
URL: https://github.com/apache/iceberg/pull/4221#discussion_r814463434
##########
File path: dell/src/main/java/org/apache/iceberg/dell/DellProperties.java
##########
@@ -38,6 +40,21 @@
*/
public static final String ECS_S3_ENDPOINT = "ecs.s3.endpoint";
+ /**
+ * Catalog prefix is used to store catalog data. If not set, use {@link
CatalogProperties#WAREHOUSE_LOCATION}.
+ * <p>
+ * The value is an EcsURI which like ecs://bucket/prefix.
+ */
+ public static final String ECS_CATALOG_PREFIX = "ecs.catalog.prefix";
Review comment:
As we usually specify a warehouse location in the FS based catalog, why
do we still need an extra `ecs.catalog.prefix` config which has the similar
meaning as the `CatalogProperties#WAREHOUSE_LOCATION` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
