openinx commented on pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#issuecomment-1053852862
I prefer to enable those following unit tests before we do any further
reviewing & porting:
```bash
➜ iceberg git:(master) find . -type f -name '*.java' | xargs grep -i
'TODO.*orc'
./core/src/test/java/org/apache/iceberg/TestMetrics.java: // TODO: The
special condition for ORC can be removed when ORC-342 is fixed
./core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: //
TODO: ORC file now not support target file size before closed
./core/src/main/java/org/apache/iceberg/io/ClusteredEqualityDeleteWriter.java:
// TODO: support ORC rolling writers
./core/src/main/java/org/apache/iceberg/io/ClusteredDataWriter.java: //
TODO: support ORC rolling writers
./core/src/main/java/org/apache/iceberg/io/ClusteredPositionDeleteWriter.java:
// TODO: support ORC rolling writers
./core/src/main/java/org/apache/iceberg/io/FanoutDataWriter.java: //
TODO: support ORC rolling writers
./flink/v1.12/flink/src/test/java/org/apache/iceberg/flink/sink/TestTaskWriters.java:
// TODO ORC don't support target file size before closed.
./flink/v1.12/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
// TODO: ORC file does not support target file size before closed.
./flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/sink/TestTaskWriters.java:
// TODO ORC don't support target file size before closed.
./flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
// TODO: ORC file does not support target file size before closed.
./flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/sink/TestTaskWriters.java:
// TODO ORC don't support target file size before closed.
./flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
// TODO: ORC file does not support target file size before closed.
./data/src/test/java/org/apache/iceberg/io/TestRollingFileWriters.java: //
TODO: add ORC once we support ORC rolling file writers
./data/src/test/java/org/apache/iceberg/data/TestLocalScan.java: // TODO:
Add multiple timestamp tests - there's an issue with ORC caching TZ in
ThreadLocal, so it's not possible
./spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
// TODO: multiple stripes for ORC
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
// TODO: support metadata structs in vectorized ORC reads
./spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
// TODO: support ORC rolling writers
./spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
// TODO: multiple stripes for ORC
./spark/v3.0/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.0/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.0/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
// TODO: support metadata structs in vectorized ORC reads
./spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
// TODO: support ORC rolling writers
./spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
@Ignore // TODO Classpath issues prevent us from actually writing to a Spark
ORC table
./spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
// TODO: multiple stripes for ORC
./spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkDataWrite.java:
// TODO: ORC file now not support target file size
./spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java:
// TODO: support metadata structs in vectorized ORC reads
./spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
// TODO: support ORC rolling writers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
