kbendick commented on pull request #4210: URL: https://github.com/apache/iceberg/pull/4210#issuecomment-1053937926
> @kbendick do we want to run CI on pushes to branches like https://github.com/apache/iceberg/tree/0.12.x or https://github.com/apache/iceberg/tree/0.13.x? If the answer is no, then I think we can go ahead and merge this. Hmmmm.... In the release workflow, there should be a corresponding tag for each of those branches. We don't presently commit to those branches outside of a release that I can think of, which would be covered by a tag. That said, I think it's not a bad idea to consider running CI for release-like branches, of the form `0.X.Y` or `X.Y.Z`: 1) The tests will be accessible in more places / more consistent locations. 2) People who run forks might apply patches to the OSS 0.13.x branch (applying additional patches on a release). If they presently use the Github Actions defined here, I would consider that a valid use case. 3) Failing CI workflows have more chance to be caught in places that matter. So I am fine with merging this now, and then opening an issue to consider also adding CI triggers when we push to a release branch, of the form `0.Y.Z`. As we don't presently use feature branches / separate active release branches (outside of during the actual release process, which will be picked up by the tag event) , it's not needed outside of those additional benefits as far as I can think of. Possibly we can just cover every branch that is within the `apache` repo, though that wouldn't handle the forks. I'm ok with opening an issue to resolve that question in a follow up, though if you'd like to consider it now (e.g. if this patch would break your CI workflow for forked changes to release branches for example), then I'm open to updating it here. Otherwise I think it's fine to wait as we won't have a release in the next week. Do you think it's necessary to handle release-like branches now or can we open an issue and get to it next week or so @nastra? 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
