aokolnychyi commented on a change in pull request #2925:
URL: https://github.com/apache/iceberg/pull/2925#discussion_r817298214
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java
##########
@@ -244,4 +245,18 @@ public boolean useTableDistributionAndOrdering() {
.defaultValue(SparkWriteOptions.USE_TABLE_DISTRIBUTION_AND_ORDERING_DEFAULT)
.parse();
}
+
+ public Long validateFromSnapshotId() {
+ return confParser.longConf()
+ .option(SparkWriteOptions.VALIDATE_FROM_SNAPSHOT_ID)
+ .parseOptional();
+ }
+
+ public IsolationLevel dynamicOverwriteIsolationLevel() {
Review comment:
Based on the discussion we had on isolation levels, I think the default
should be `null` (i.e. no validation). Serializable isolation should mean
validate both new data files and all types of deletes. Snapshot isolation would
mean validate just all types of deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
