kbendick commented on a change in pull request #4246:
URL: https://github.com/apache/iceberg/pull/4246#discussion_r817304711
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java
##########
@@ -71,14 +69,6 @@
.noDefaultValue()
.withDescription("Table name managed in the underlying iceberg
catalog and database.");
- // Flink 1.13.x change the return type from CatalogTable interface to
ResolvedCatalogTable which extends the
- // CatalogTable. Here we use the dynamic method loading approach to avoid
adding explicit CatalogTable or
- // ResolvedCatalogTable class into the iceberg-flink-runtime jar for
compatibility purpose.
- private static final DynMethods.UnboundMethod GET_CATALOG_TABLE =
DynMethods.builder("getCatalogTable")
- .impl(Context.class, "getCatalogTable")
- .orNoop()
- .build();
Review comment:
Good catch @hililiwei!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
