RussellSpitzer commented on a change in pull request #4211:
URL: https://github.com/apache/iceberg/pull/4211#discussion_r818157745
##########
File path: core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java
##########
@@ -1143,4 +1145,63 @@ public void testExpireWithDefaultSnapshotAge() {
Sets.newHashSet(firstSnapshot.manifestListLocation(),
secondSnapshot.manifestListLocation()),
deletedFiles);
}
+
+ @Test
+ public void testExpireWithDeleteFiles() {
+ Assume.assumeTrue("Delete files only supported in V2 spec", formatVersion
== 2);
+
+ // Data Manifest => File_A
+ table.newAppend()
+ .appendFile(FILE_A)
+ .commit();
+ Snapshot firstSnapshot = table.currentSnapshot();
+
+ // Data Manifest => FILE_A
+ // Delete Manifest => FILE_A_DELETES
+ table.newRowDelta()
+ .addDeletes(FILE_A_DELETES)
+ .commit();
+ Snapshot secondSnapshot = table.currentSnapshot();
+ Assert.assertEquals("Should have 1 data manifests", 1,
secondSnapshot.dataManifests().size());
+ Assert.assertEquals("Should have 1 delete manifest", 1,
secondSnapshot.deleteManifests().size());
+
+ // FILE_A and FILE_A_DELETES move into "DELETED" state
+ table.newRewrite()
+ .rewriteFiles(
+ ImmutableSet.of(FILE_A), ImmutableSet.of(FILE_A_DELETES), //
deleted
+ ImmutableSet.of(FILE_B), ImmutableSet.of(FILE_B_DELETES)) // added
+ .validateFromSnapshot(secondSnapshot.snapshotId())
+ .commit();
+ Snapshot thirdSnapshot = table.currentSnapshot();
+ Set<ManifestFile> manifestOfDeletedFiles =
thirdSnapshot.allManifests().stream().filter(
+ ManifestFile::hasDeletedFiles).collect(Collectors.toSet());
+ Assert.assertEquals("Should have two manifest of deleted files", 2,
Review comment:
nit: manifests of deleted files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
