dramaticlly opened a new pull request #4262: URL: https://github.com/apache/iceberg/pull/4262
First step of closing https://github.com/apache/iceberg/issues/4250 This is my first iceberg python contribution, so there might be some naive mistake and please let me know so I can jump to fix, most of the code is refactoring from https://github.com/apache/iceberg/blob/master/python_legacy/iceberg/api/expressions/literals.py to our latest python module Change highlights - Refactor all static method to module level methods to be more pythonic - Adopt the `TimestampTzType` and `TimestampType` from types, previous we only have `TimestampType` with custom logic on `with_timezone` and `without_timezone` - have 2 TODOs on byte buffer conversion and rely on TRUE/FALSE expression, which I am try to fix it in later PR as this is already pretty large to review - I also temporarily opt-out the test coverage 90% requirement for literal class as there points above and I will add more tests for the class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
