jackye1995 commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r819183477
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -81,4 +81,8 @@ private CatalogProperties() {
public static final String APP_ID = "app-id";
public static final String USER = "user";
+ public static final String IO_METRICS_IMPL = "io.metrics-impl";
+ public static final String IO_METRICS_IMPL_DEFAULT =
"org.apache.iceberg.hadoop.HadoopMetricsContext";
+ public static final String IO_METRICS_SCHEME = "io.metrics-scheme";
Review comment:
I think there still needs to be a way for users to input some sort of
grouping concept in the metrics, for example users who use `S3FileIO` for
`gs://` should expect metrics to land to some different metrics namespace from
`s3://`. Scheme seems to be a good way to do that. For our CloudWatch metrics
integration. we will match this to the CloudWatch namespace concept, where the
metrics will by default be emitted to a namepace `iceberg/<scheme>` such as
`iceberg/s3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
