kingeasternsun commented on pull request #3973: URL: https://github.com/apache/iceberg/pull/3973#issuecomment-1058746869
> > > I think most of my main concerns are wrapped up, just some formatting fixes left. I think as a follow up we should deprecate all the public methods not using "parallelism", not important to do it right int his PR though. > > > > > > I thinks the sentence ` int hist PR` should be `in this PR` ? @RussellSpitzer . And did you mean `deprecate all the public methods not using "parallelism" ` in another PR ? > > There are a bunch of public utility methods now that have a version which takes parallelism and a version which does not. I think with this PR we have finished changing all internal usages to always specify parallelism so we are probably good with removing the non-parallel arg versions in a future release. Thanks, I got It. So I just need to keep the code now as it is , And waiting for it to be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
