dylzlt commented on pull request #4258: URL: https://github.com/apache/iceberg/pull/4258#issuecomment-1058748283
> Sorry I just read the original issue as it wasnt linked (#3895 ) , I get it now and think would be great to have a Javadoc on this class. > > I think the problem is that this proposed Javadoc is developer-facing, and should be user-facing. Specifically, the 'we' here seems like its meant for developer to know what exception to throw... but it should be instead describing to user what situations to expect it from. Oh, thanks for your suggestion. You mean the Javadoc is used to tell user arguments inconsistencies when they catch the ValidationException, rather than tell developer how to use it(because this is developer rule)?Is my understanding right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
