szehon-ho commented on a change in pull request #4262: URL: https://github.com/apache/iceberg/pull/4262#discussion_r820016760
########## File path: python/src/iceberg/expression/literals.py ########## @@ -0,0 +1,737 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import datetime +import uuid +from decimal import ROUND_HALF_UP, Decimal +from functools import singledispatch, singledispatchmethod + +import pytz + +from iceberg.types import ( + BinaryType, + BooleanType, + DateType, + DecimalType, + DoubleType, + FixedType, + FloatType, + IntegerType, + LongType, + Singleton, + StringType, + TimestampType, + TimestamptzType, + TimeType, + UUIDType, +) + +JAVA_MAX_INT = 2147483647 +JAVA_MIN_INT = -2147483648 +JAVA_MAX_FLOAT = 3.4028235e38 +JAVA_MIN_FLOAT = -3.4028235e38 +EPOCH = datetime.datetime.utcfromtimestamp(0) +EPOCH_DAY = EPOCH.date() + + +""" +Iceberg literal is wrapper class used in expressions, which return unbound predicates +It's being organized as below +Literal +|-- AboveMax +|-- BelowMin +|-- BaseLiteral + |-- StringLiteral + |-- FixedLiteral + |-- BinaryLiteral + |-- ComparableLiteral + |-- BooleanLiteral + |-- IntegerLiteral + |-- LongLiteral + |-- FloatLiteral + |-- DoubleLiteral + |-- DateLiteral + |-- TimeLiteral + |-- TimestampLiteral + |-- DecimalLiteral + |-- UUIDLiteral +""" + + +class Literal: + def to(self, type_var): + raise NotImplementedError() + + def to_byte_buffer(self): + raise NotImplementedError() + + +@singledispatch +def of(value): + """ + A generic Literal factory to construct a iceberg Literal based on python primitive data type + using dynamic overloading + + Args: + value(python primitive type): the value to be associated with literal + + Example: + import iceberg.expressions.literals + >>> iceberg.expressions.literals.of(1) + IntegerLiteral(1) + """ + raise TypeError(f"Unimplemented Type Literal for value: {value}") + + [email protected] +def _of(value: bool): + return BooleanLiteral(value) + + [email protected] +def _of(value: int): + """ + Upgrade to long is python int is outside the JAVA_MIN_INT and JAVA_MAX_INT Review comment: Reading the sentence a few times, is the first "is" a typo and should be "as"? ########## File path: python/src/iceberg/expression/literals.py ########## @@ -0,0 +1,737 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import datetime +import uuid +from decimal import ROUND_HALF_UP, Decimal +from functools import singledispatch, singledispatchmethod + +import pytz + +from iceberg.types import ( + BinaryType, + BooleanType, + DateType, + DecimalType, + DoubleType, + FixedType, + FloatType, + IntegerType, + LongType, + Singleton, + StringType, + TimestampType, + TimestamptzType, + TimeType, + UUIDType, +) + +JAVA_MAX_INT = 2147483647 +JAVA_MIN_INT = -2147483648 +JAVA_MAX_FLOAT = 3.4028235e38 +JAVA_MIN_FLOAT = -3.4028235e38 +EPOCH = datetime.datetime.utcfromtimestamp(0) +EPOCH_DAY = EPOCH.date() + + +""" +Iceberg literal is wrapper class used in expressions, which return unbound predicates +It's being organized as below +Literal +|-- AboveMax +|-- BelowMin +|-- BaseLiteral + |-- StringLiteral + |-- FixedLiteral + |-- BinaryLiteral + |-- ComparableLiteral + |-- BooleanLiteral + |-- IntegerLiteral + |-- LongLiteral + |-- FloatLiteral + |-- DoubleLiteral + |-- DateLiteral + |-- TimeLiteral + |-- TimestampLiteral + |-- DecimalLiteral + |-- UUIDLiteral +""" + + +class Literal: + def to(self, type_var): + raise NotImplementedError() + + def to_byte_buffer(self): + raise NotImplementedError() + + +@singledispatch +def of(value): + """ + A generic Literal factory to construct a iceberg Literal based on python primitive data type + using dynamic overloading + + Args: + value(python primitive type): the value to be associated with literal + + Example: + import iceberg.expressions.literals + >>> iceberg.expressions.literals.of(1) + IntegerLiteral(1) + """ + raise TypeError(f"Unimplemented Type Literal for value: {value}") + + [email protected] +def _of(value: bool): + return BooleanLiteral(value) + + [email protected] +def _of(value: int): + """ + Upgrade to long is python int is outside the JAVA_MIN_INT and JAVA_MAX_INT + """ + if value < JAVA_MIN_INT or value > JAVA_MAX_INT: + return LongLiteral(value) + return IntegerLiteral(value) + + [email protected] +def _of(value: float): + """ + Upgrade to double is python float is outside the JAVA_MIN_FLOAT and JAVA_MAX_FLOAT + """ + if value < JAVA_MIN_FLOAT or value > JAVA_MAX_FLOAT: + return DoubleLiteral(value) + return FloatLiteral(value) + + [email protected] +def _of(value: str): + return StringLiteral(value) + + [email protected] +def _of(value: uuid.UUID): + return UUIDLiteral(value) + + [email protected] +def _of(value: bytes): + return FixedLiteral(value) + + [email protected] +def _of(value: bytearray): + return BinaryLiteral(value) + + [email protected] +def _of(value: Decimal): + return DecimalLiteral(value) + + +class BaseLiteral(Literal): + """Base literal which have a value and can be converted between types""" Review comment: super nit: "literal which has" ########## File path: python/src/iceberg/expression/literals.py ########## @@ -0,0 +1,737 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import datetime +import uuid +from decimal import ROUND_HALF_UP, Decimal +from functools import singledispatch, singledispatchmethod + +import pytz + +from iceberg.types import ( + BinaryType, + BooleanType, + DateType, + DecimalType, + DoubleType, + FixedType, + FloatType, + IntegerType, + LongType, + Singleton, + StringType, + TimestampType, + TimestamptzType, + TimeType, + UUIDType, +) + +JAVA_MAX_INT = 2147483647 +JAVA_MIN_INT = -2147483648 +JAVA_MAX_FLOAT = 3.4028235e38 +JAVA_MIN_FLOAT = -3.4028235e38 +EPOCH = datetime.datetime.utcfromtimestamp(0) +EPOCH_DAY = EPOCH.date() + + +""" +Iceberg literal is wrapper class used in expressions, which return unbound predicates +It's being organized as below +Literal +|-- AboveMax +|-- BelowMin +|-- BaseLiteral + |-- StringLiteral + |-- FixedLiteral + |-- BinaryLiteral + |-- ComparableLiteral + |-- BooleanLiteral + |-- IntegerLiteral + |-- LongLiteral + |-- FloatLiteral + |-- DoubleLiteral + |-- DateLiteral + |-- TimeLiteral + |-- TimestampLiteral + |-- DecimalLiteral + |-- UUIDLiteral +""" + + +class Literal: + def to(self, type_var): + raise NotImplementedError() + + def to_byte_buffer(self): + raise NotImplementedError() + + +@singledispatch +def of(value): + """ + A generic Literal factory to construct a iceberg Literal based on python primitive data type Review comment: super nit: "an Iceberg Literal"? ########## File path: python/src/iceberg/expression/literals.py ########## @@ -0,0 +1,737 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import datetime +import uuid +from decimal import ROUND_HALF_UP, Decimal +from functools import singledispatch, singledispatchmethod + +import pytz + +from iceberg.types import ( + BinaryType, + BooleanType, + DateType, + DecimalType, + DoubleType, + FixedType, + FloatType, + IntegerType, + LongType, + Singleton, + StringType, + TimestampType, + TimestamptzType, + TimeType, + UUIDType, +) + +JAVA_MAX_INT = 2147483647 +JAVA_MIN_INT = -2147483648 +JAVA_MAX_FLOAT = 3.4028235e38 +JAVA_MIN_FLOAT = -3.4028235e38 +EPOCH = datetime.datetime.utcfromtimestamp(0) +EPOCH_DAY = EPOCH.date() + + +""" +Iceberg literal is wrapper class used in expressions, which return unbound predicates +It's being organized as below +Literal +|-- AboveMax +|-- BelowMin +|-- BaseLiteral + |-- StringLiteral + |-- FixedLiteral + |-- BinaryLiteral + |-- ComparableLiteral + |-- BooleanLiteral + |-- IntegerLiteral + |-- LongLiteral + |-- FloatLiteral + |-- DoubleLiteral + |-- DateLiteral + |-- TimeLiteral + |-- TimestampLiteral + |-- DecimalLiteral + |-- UUIDLiteral +""" + + +class Literal: + def to(self, type_var): + raise NotImplementedError() + + def to_byte_buffer(self): + raise NotImplementedError() + + +@singledispatch +def of(value): + """ + A generic Literal factory to construct a iceberg Literal based on python primitive data type + using dynamic overloading + + Args: + value(python primitive type): the value to be associated with literal + + Example: + import iceberg.expressions.literals + >>> iceberg.expressions.literals.of(1) + IntegerLiteral(1) + """ + raise TypeError(f"Unimplemented Type Literal for value: {value}") + + [email protected] +def _of(value: bool): + return BooleanLiteral(value) + + [email protected] +def _of(value: int): + """ + Upgrade to long is python int is outside the JAVA_MIN_INT and JAVA_MAX_INT + """ + if value < JAVA_MIN_INT or value > JAVA_MAX_INT: + return LongLiteral(value) + return IntegerLiteral(value) + + [email protected] +def _of(value: float): + """ + Upgrade to double is python float is outside the JAVA_MIN_FLOAT and JAVA_MAX_FLOAT Review comment: Same as above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
