jun-he commented on a change in pull request #3450:
URL: https://github.com/apache/iceberg/pull/3450#discussion_r820165670
##########
File path: python/src/iceberg/types.py
##########
@@ -43,6 +46,11 @@ def __new__(cls, *args, **kwargs):
return cls._instance
+class Truncatable:
+ def truncate(self, value, width: int):
+ raise ValueError(f"Cannot truncate type: {self}")
Review comment:
Yep, I thought about that. I did not use it to keep the code simple. I
will update the code to use ABC class here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
