rdblue commented on a change in pull request #3450:
URL: https://github.com/apache/iceberg/pull/3450#discussion_r820302439



##########
File path: python/src/iceberg/types.py
##########
@@ -41,6 +45,12 @@ def __new__(cls, *args, **kwargs):
         return cls._instance
 
 
+class Truncatable(ABC):

Review comment:
       This should be parameterized because the `truncate` method always 
returns the type passed in, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to