rdblue commented on a change in pull request #3188:
URL: https://github.com/apache/iceberg/pull/3188#discussion_r820931210
##########
File path: site/docs/spec.md
##########
@@ -357,6 +357,7 @@ A manifest file must store the partition spec and other
metadata as properties i
| _required_ | _required_ | `partition-spec` | JSON fields representation
of the partition spec used to write the manifest |
| _optional_ | _required_ | `partition-spec-id` | ID of the partition spec
used to write the manifest as a string |
| _optional_ | _required_ | `format-version` | Table format version number
of the manifest as a string |
+| _optional_ | _optional_ | `object-type` | Type of object this metadata
file is for: "table" or "view". Default is "table". |
Review comment:
We need to be careful about using the term "manifest". That refers to
manifest files in the table spec and not these metadata files.
I'm okay with "spec-type" or "object-type". I don't think we should worry
too much about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
