rdblue commented on a change in pull request #4244:
URL: https://github.com/apache/iceberg/pull/4244#discussion_r821135627
##########
File path: build.gradle
##########
@@ -203,6 +203,10 @@ project(':iceberg-common') {
}
project(':iceberg-core') {
+ test {
+ useJUnitPlatform()
+ }
Review comment:
We have a lot of parameterized tests that don't require JUnit5. Here's
an example:
https://github.com/apache/iceberg/blob/master/api%2Fsrc%2Ftest%2Fjava%2Forg%2Fapache%2Ficeberg%2Fexpressions%2FTestExpressionSerialization.java#L31-L72
I generally prefer not to change the build in small PRs unless we need to.
If we want to move to JUnit5, then we should take a look at that and discuss it
on the dev list. My main concern there is the reordering of assert method
arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
