amogh-jahagirdar commented on a change in pull request #4273:
URL: https://github.com/apache/iceberg/pull/4273#discussion_r821193851
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -143,6 +143,14 @@ private TableProperties() {
public static final String DELETE_ORC_BLOCK_SIZE_BYTES =
"write.delete.orc.block-size-bytes";
public static final long ORC_BLOCK_SIZE_BYTES_DEFAULT = 256L * 1024 * 1024;
// 256 MB
+ public static final String ORC_COMPRESSION = "write.orc.compression-codec";
+ public static final String DELETE_ORC_COMPRESSION =
"write.delete.orc.compression-codec";
+ public static final String ORC_COMPRESSION_DEFAULT = "zlib";
Review comment:
I think ORC as a format does not support GZIP.
https://orc.apache.org/api/orc-core/org/apache/orc/CompressionKind.html
Engines like Presto/Trino tend to have ZLIB as a default compression mode
for ORC. Under the hood for both GZIP/Zlib is the same "Deflate" compression
algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
