hililiwei commented on pull request #3810: URL: https://github.com/apache/iceberg/pull/3810#issuecomment-1061324052
> @openinx, @hililiwei, I think we need to revert this. It looks like the `dataContext` and `deleteContext` methods accept Hadoop Configuration objects rather than property maps. > > Iceberg doesn't use Hadoop Configuration. We can either directly fix this to work like the Parquet contexts with another PR, or I think we should revert and open a replacement PR. What do you think is the right way forward? I understand what you mean roughly. Let me mention a separate PR, it may goes beyond the this PR content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
