zhongyujiang edited a comment on pull request #3810: URL: https://github.com/apache/iceberg/pull/3810#issuecomment-1061772959
@openinx, I think what @rdblue means is that in current logic Iceberg configuration might be overridden by Hadoop configuration , for example: when Hadoop configuraion is configed a property "orc.compress" = "snappy" and no corresponding property has been configed in Iceberg table props, In the present context ORC will use snappy for compress as configed in Hadoop. But the correct procedure is use default codec configed in `TableProperties`. So we need a props map to receive table props passed in, then set corresponding ORC props in Hadoop configuration after parsing, just like Parquet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
