openinx commented on pull request #3810: URL: https://github.com/apache/iceberg/pull/3810#issuecomment-1062485900
Okay, I think I get the drawback about the current ORC builder ( which copied the table properties map into hadoop conf and just use the hadoop conf as the source of truth): * As @zhongyujiang said, the default value of iceberg standardized settings will be replaced by the hadoop config values. * Non-standardized iceberg settings which are added in the iceberg table properties will be affected to the underlying ORC readers & writers. * The standardized iceberg settings will be added to hadoop configuration, which may pollute the hadoop configuration. I agree to make another PR to change the ORC configs parser as the @rdblue suggested. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
