aokolnychyi commented on a change in pull request #4303:
URL: https://github.com/apache/iceberg/pull/4303#discussion_r823099483
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -35,7 +35,7 @@
private Long startingSnapshotId = null;
private Expression conflictDetectionFilter = null;
private boolean validateNewDataFiles = false;
- private boolean validateNewDeleteFiles = false;
+ private boolean validateNewDeletes = false;
Review comment:
Cause we not only validate added delete files but also deleted data
files. We have two types of deletes to cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
