aokolnychyi commented on a change in pull request #3411:
URL: https://github.com/apache/iceberg/pull/3411#discussion_r823158313
##########
File path: core/src/main/java/org/apache/iceberg/Partitioning.java
##########
@@ -210,7 +211,8 @@ public static StructType partitionType(Table table) {
}
Map<Integer, PartitionField> fieldMap = Maps.newHashMap();
- List<NestedField> structFields = Lists.newArrayList();
+ Map<Integer, Type> typeMap = Maps.newHashMap();
+ Map<Integer, String> nameMap = Maps.newHashMap();
Review comment:
Looks like we are using field IDs while projecting values from the
common representation in Spark.
At least, that part is working.
```
protected Map<Integer, StructProjection>
buildPartitionProjections(Types.StructType partitionType,
Map<Integer, PartitionSpec> specs) {
Map<Integer, StructProjection> partitionProjections = Maps.newHashMap();
specs.forEach((specID, spec) ->
partitionProjections.put(specID,
StructProjection.create(partitionType, spec.partitionType()))
);
return partitionProjections;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
